[webkit-reviews] review granted: [Bug 115287] ~BlockAllocator should ASSERT that it has no more Regions left : [Attachment 199879] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 115287: ~BlockAllocator should ASSERT that it has no more Regions left
https://bugs.webkit.org/show_bug.cgi?id=115287

Attachment 199879: Patch
https://bugs.webkit.org/attachment.cgi?id=199879&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199879&action=review


r=me

> Source/JavaScriptCore/heap/BlockAllocator.cpp:61
> +    ASSERT(allRegionSetsAreEmpty() && m_emptyRegions.isEmpty());

You could make this two separate ASSERTs so it's easy to see which one is
failing.

> Source/JavaScriptCore/heap/BlockAllocator.h:75
> +	   bool isEmpty()

I'd make this const.

> Source/JavaScriptCore/heap/BlockAllocator.h:88
> +    bool allRegionSetsAreEmpty();

Ditto.