[webkit-reviews] review granted: [Bug 115083] fourthTier: CFA should defend against results seeming inconsistent due to a watchpoint firing during compilation : [Attachment 199874] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 115083: fourthTier: CFA should defend against results seeming inconsistent
due to a watchpoint firing during compilation
https://bugs.webkit.org/show_bug.cgi?id=115083

Attachment 199874: the patch
https://bugs.webkit.org/attachment.cgi?id=199874&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199874&action=review


r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1353
> +    if
(m_jit.graph().m_watchpoints.isStillValid(m_jit.graph().globalObjectFor(node->c
odeOrigin)->masqueradesAsUndefinedWatchpoint())) {

Let's add a helper function for this, since it's repeated in so many places.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:-3005
> -   
stringPrototypeStructure->addTransitionWatchpoint(speculationWatchpoint(NotStri
ngObject));

In future, when we have a compilation thread, let's add an ASSERT to
WatchpointSet that prohibits access from the compilation thread.

We'll see -- it might be appropriate to add stuff like that to SymbolTable
and/or Structure, as well.