[webkit-reviews] review denied: [Bug 114742] [texmap] draw content if graphics layer displays a video : [Attachment 199679] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 26 10:39:54 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 114742: [texmap] draw content if graphics layer displays a video
https://bugs.webkit.org/show_bug.cgi?id=114742

Attachment 199679: Patch
https://bugs.webkit.org/attachment.cgi?id=199679&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
This is also wrong. I'm not sure why you think that having accelerated video
means that you have to call setDrawsContent() on the main graphics layer.

The graphics layer can have a contents layer for various reasons: video, WebGL,
image, solid color. On Mac at least, none of those types of content layer need
to be explicitly drawn (although WebGL does need a hint that the contents have
changed sometimes).

In the TextureMapper case, does the video go into a contents layer? In this
case, is it considered like painted content that needs backing store?


More information about the webkit-reviews mailing list