[webkit-reviews] review granted: [Bug 115033] Add move semantics to RefPtr : [Attachment 199804] patch v6
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 26 07:38:06 PDT 2013
Anders Carlsson <andersca at apple.com> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 115033: Add move semantics to RefPtr
https://bugs.webkit.org/show_bug.cgi?id=115033
Attachment 199804: patch v6
https://bugs.webkit.org/attachment.cgi?id=199804&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
(In reply to comment #25)
> That's great! but how about just
>
> RefPtr<T>(std::move(o)).swap(*this);
> return *this;
I think it's easier to read with an explicit temporary. Please make that
change, r=me.
More information about the webkit-reviews
mailing list