[webkit-reviews] review granted: [Bug 108201] [WK2][EFL] Skip cancel fullscreen request if not requested by FullScreen API : [Attachment 185285] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 108201: [WK2][EFL] Skip cancel fullscreen request if not requested by
FullScreen API
https://bugs.webkit.org/show_bug.cgi?id=108201

Attachment 185285: Patch
https://bugs.webkit.org/attachment.cgi?id=185285&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185285&action=review


r=me since it fixes your crash, and the code is platform-specific. I don't like
the m_isFullScreen name though.

> Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h:105
> +    bool m_isFullScreen;

This name seems a bit too general, since it's only true if full screen mode was
entered through the FullScreen API.
Not sure what to call it.. maybe m_hasEnteredFullScreenMode? (Or maybe you have
multiple states like the Mac port's FullScreenState? If so then it's still too
general.)