[webkit-reviews] review granted: [Bug 109023] <meter> element not exposed to accessibility : [Attachment 199694] patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 109023: <meter> element not exposed to accessibility
https://bugs.webkit.org/show_bug.cgi?id=109023

Attachment 199694: patch
https://bugs.webkit.org/attachment.cgi?id=199694&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199694&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:233
> +    // If an object can't have children, then it is using this method to
help
> +    // calculate some internal property (like its description).
> +    // In this case, it should check the Node level for children in case
they're
> +    // not rendered (like a <meter> element).
> +    if (!firstChild && !canHaveChildren())
> +	   return AccessibilityNodeObject::firstChild();
> +

Is any code anywhere ever going to even come close to assuming that
AccessibilityRenderObject::firstChild() is an AccessibilityRenderObject? (and
then just static_casting or something?) Can we make sure that it won't?