[webkit-reviews] review granted: [Bug 115185] Thread safety issues in WKCustomProtocol : [Attachment 199681] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 115185: Thread safety issues in WKCustomProtocol
https://bugs.webkit.org/show_bug.cgi?id=115185

Attachment 199681: Patch v1
https://bugs.webkit.org/attachment.cgi?id=199681&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199681&action=review


r=me assuming WKCustomProtocol is ThreadSafeRefCounted.

> Source/WebKit2/Shared/Network/CustomProtocols/CustomProtocolManager.h:101
> +    RetainPtr<WKCustomProtocol> protocolForID(uint64_t customProtocolID);

I'd add a comment explaining the RetainPtr. Looking at it, I already foolishly
want to remove it :)