[webkit-reviews] review denied: [Bug 108425] [Qt] Adjust the way of determining whether build-webkit needs full incremental build : [Attachment 199569] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Seulgi Kim
<seulgikim at company100.net>'s request for review:
Bug 108425: [Qt] Adjust the way of determining whether build-webkit needs full
incremental build
https://bugs.webkit.org/show_bug.cgi?id=108425

Attachment 199569: Patch
https://bugs.webkit.org/attachment.cgi?id=199569&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
The whole point is to ensure that we have a successful build before adding to
BUILTREVISIONS. Why do you think the "second full incremental build is
unnecessary"? What if 'make qmake_all' fails to generate a project file, or
generating sources fails? Will we still end up running qmake for the whole
project, even with -j1?