[webkit-reviews] review granted: [Bug 115147] Stack guards are too conservative : [Attachment 199616] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 115147: Stack guards are too conservative
https://bugs.webkit.org/show_bug.cgi?id=115147

Attachment 199616: Patch
https://bugs.webkit.org/attachment.cgi?id=199616&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199616&action=review


Would be good to explain what motivated these new limits, so we don't make the
same mistake twice.

>> Source/JavaScriptCore/interpreter/Interpreter.cpp:122
>> +	const size_t DEFAULT_REQUIRED_STACK = 256 * 1024;
> 
> DEFAULT_REQUIRED_STACK is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming/underscores] [4]

I think we should just remove DEFAULT_REQUIRED_STACK entirely -- it's very
weird to have two different minimum values. In truth, the smaller minimum is
the bottom line.