[webkit-reviews] review requested: [Bug 115138] [QNX][ARM] Use hardware integer division where available : [Attachment 199614] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 20:48:39 PDT 2013


Cosmin Truta <ctruta at gmail.com> has asked  for review:
Bug 115138: [QNX][ARM] Use hardware integer division where available
https://bugs.webkit.org/show_bug.cgi?id=115138

Attachment 199614: Patch
https://bugs.webkit.org/attachment.cgi?id=199614&action=review

------- Additional Comments from Cosmin Truta <ctruta at gmail.com>
I initially made DFG::isARMWithIntegerDiv() in order to use it as it's the case
with DFG::isX86(), i.e. when it's not protected by #if CPU(...); but then I
noticed I had used it inside in ARM-specific code also, interchangeably (and
inconsistently) with MacroAssembler::supportsIntegerDiv(). I am now modifying
the previous patch: I use MacroAssembler::supportsIntegerDiv() consistently
inside ARM-specific code, and DFG::isARMWithIntegerDiv() only in the rare cases
outside.

I also simplified isIntegerDivSupported().


More information about the webkit-reviews mailing list