[webkit-reviews] review requested: [Bug 115138] [QNX][ARM] Use hardware integer division where available : [Attachment 199607] Patch

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at gmail.com> has asked  for review:
Bug 115138: [QNX][ARM] Use hardware integer division where available
https://bugs.webkit.org/show_bug.cgi?id=115138

Attachment 199607: Patch
https://bugs.webkit.org/attachment.cgi?id=199607&action=review

------- Additional Comments from Cosmin Truta <ctruta at gmail.com>
(In reply to comment #3)
> What you should do is:
>     -MacroAssembler::supportsIntegerDiv() is a _compile time_ constant for
everything but QNX
>     [...]

Done. This allowed me to simplify preprocessor conditionals in other places,
and rely on the fact that this gets resolved at compile time whenever possible.


> That makes no sense. What if you  are ArithDiv and
MacroAssembler::supportsIntegerDiv() evaluate to false, you just silently
ignore the operation?