[webkit-reviews] review denied: [Bug 115143] Add support for Math.imul : [Attachment 199571] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 115143: Add support for Math.imul
https://bugs.webkit.org/show_bug.cgi?id=115143

Attachment 199571: Patch
https://bugs.webkit.org/attachment.cgi?id=199571&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199571&action=review


I think FixupPhase is borked - it should call the fixIntEdge() thingy.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:215
> +	       setUseKindAndUnboxIfProfitable<Int32Use>(node->child1());
> +	       setUseKindAndUnboxIfProfitable<Int32Use>(node->child2());

Why doesn't this call fixIntEdge() instead, like the bit ops do?