[webkit-reviews] review granted: [Bug 115134] Polling based watchdog for the DFG : [Attachment 199527] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 115134: Polling based watchdog for the DFG
https://bugs.webkit.org/show_bug.cgi?id=115134

Attachment 199527: the patch.
https://bugs.webkit.org/attachment.cgi?id=199527&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199527&action=review


r=me

> Source/JavaScriptCore/runtime/Watchdog.cpp:82
>	   // And if we've previously compiled any functions, we need to deopt

"revert" is a better word than "deopt" here -- we're not necessarily forcing a
less optimal form -- we're just throwing away the form we have right now, and
letting the engine choose whatever form it chooses the next time the function
executes.

> Source/JavaScriptCore/runtime/Watchdog.cpp:83
>	   // them because they don't habe the needed polling checks yet.

Typo: "habe".