[webkit-reviews] review granted: [Bug 115131] REGRESSION (r146544): Once a custom font is cached to disk, it starts failing to render until the page is refreshed. : [Attachment 199521] Patch v1 - Don't replace encoded data for a CachedFont that has ever created a FontCustomPlatformData object

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 115131: REGRESSION (r146544): Once a custom font is cached to disk, it
starts failing to render until the page is refreshed.
https://bugs.webkit.org/show_bug.cgi?id=115131

Attachment 199521: Patch v1 - Don't replace encoded data for a CachedFont that
has ever created a FontCustomPlatformData object
https://bugs.webkit.org/attachment.cgi?id=199521&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199521&action=review


> Source/WebCore/loader/cache/CachedFont.h:67
> +    virtual bool shouldTryReplaceEncodedData() const;

I think that it's a "may", not "should".

> Source/WebCore/loader/cache/CachedResource.h:299
>      virtual PurgePriority purgePriority() const { return PurgeDefault; }
> +    virtual bool shouldTryReplaceEncodedData() const { return true; }

OVERRIDE