[webkit-reviews] review denied: [Bug 115033] Add move semantics to RefPtr : [Attachment 199413] patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 14:43:45 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 115033: Add move semantics to RefPtr
https://bugs.webkit.org/show_bug.cgi?id=115033

Attachment 199413: patch v4
https://bugs.webkit.org/attachment.cgi?id=199413&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199413&action=review


> Source/WTF/wtf/RefPtr.h:159
> +	   T* ptr = m_ptr;
> +	   m_ptr = o.release().leakRef();
> +	   derefIfNotNull(ptr);
> +	   return *this;

With this, what if I do this?

RefPtr a = [...];
a = std::move(a);


More information about the webkit-reviews mailing list