[webkit-reviews] review granted: [Bug 115055] [BlackBerry] Do not clear focus on a node when tapping on form controls : [Attachment 199323] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Nima Ghanavatian
<nghanavatian at blackberry.com>'s request for review:
Bug 115055: [BlackBerry] Do not clear focus on a node when tapping on form
controls
https://bugs.webkit.org/show_bug.cgi?id=115055

Attachment 199323: Patch
https://bugs.webkit.org/attachment.cgi?id=199323&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199323&action=review


Looks good, but please fix the ChangeLog before landing.

> Source/WebKit/blackberry/ChangeLog:12
> +	   or highlighted text, we must maintain focus the current focus

I don't get the "focus the current focus" part.

> Source/WebKit/blackberry/ChangeLog:14
> +	   context to trigger off of TouchHold instead of TouchPress.

I think you do not want the first 'of' there.