[webkit-reviews] review denied: [Bug 114260] [GTK][AC] Clean up unused code for clutter based AC : [Attachment 198904] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 08:01:21 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 114260: [GTK][AC] Clean up unused code for clutter based AC
https://bugs.webkit.org/show_bug.cgi?id=114260

Attachment 198904: Patch
https://bugs.webkit.org/attachment.cgi?id=198904&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198904&action=review


> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:270
> -	   graphicsLayerActorRemoveAll(GRAPHICS_LAYER_ACTOR(actor.get()));
> +	   clutter_actor_remove_all_children(actor.get());

I would prefer if you split this in two patches, one dealing with cleaning up
the children management stuff and one cleaning up scrolling/translation.


More information about the webkit-reviews mailing list