[webkit-reviews] review granted: [Bug 115014] Web Inspector: Add number to list from remote web inspector. : [Attachment 199379] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 24 00:35:32 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has granted Seokju Kwon
<seokju.kwon at gmail.com>'s request for review:
Bug 115014: Web Inspector: Add number to list from remote web inspector.
https://bugs.webkit.org/show_bug.cgi?id=115014
Attachment 199379: Patch
https://bugs.webkit.org/attachment.cgi?id=199379&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199379&action=review
> Source/WebKit2/UIProcess/InspectorServer/front-end/inspectorPageIndex.html:22
> + var page = document.createElement("li");
> + page.appendChild(link);
> + pageList.appendChild(page);
page -> pageListItem or something like that.
The variable "page" should only be use for "pages[i]" in this context.
More information about the webkit-reviews
mailing list