[webkit-reviews] review denied: [Bug 115063] Improve performance of the RenderLayerCompositor::OverlapMap : [Attachment 199336] Patch V1

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 115063: Improve performance of the RenderLayerCompositor::OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=115063

Attachment 199336: Patch V1
https://bugs.webkit.org/attachment.cgi?id=199336&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199336&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:123
> +    Vector<IntRect> m_layerRects;
> +    IntRect m_boundingBox;
> +};

This is becoming more like a Region. How does the performance of this compare
with a Region? (I think we used them in the past with poor results.)

> Source/WebCore/rendering/RenderLayerCompositor.cpp:943
> +    if (overlapMap && !overlapMap->isEmpty() &&
compositingState.m_testingOverlap && !requiresCompositingLayer(layer)) {

requiresCompositingLayer() is now getting called twice for each
computeCompositingRequirements() call; once here, and once inside
needsToBeComposited(). It's not very cheap, so we should refactor to call it
only once.