[webkit-reviews] review granted: [Bug 114984] [CSS Exclusions] Improve ExclusionPolygon smart pointer safety : [Attachment 199128] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 114984: [CSS Exclusions] Improve ExclusionPolygon smart pointer safety
https://bugs.webkit.org/show_bug.cgi?id=114984

Attachment 199128: Patch
https://bugs.webkit.org/attachment.cgi?id=199128&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199128&action=review


r=me.

> Source/WebCore/rendering/ExclusionShape.cpp:159
> +	   exclusionShape = createExclusionPolygon(vertices.release(),
polygon->windRule());

I am not necessarily loving it that the vertices are created here and passed
from one ctor to the next multiple times, but this particular change seems
reasonable.