[webkit-reviews] review granted: [Bug 114412] Add platform support for -webkit-background-blend-mode to CG context with background color : [Attachment 197724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 23 12:18:10 PDT 2013


Dean Jackson <dino at apple.com> has granted Mihai Tica <mitica at adobe.com>'s
request for review:
Bug 114412: Add platform support for -webkit-background-blend-mode to CG
context with background color
https://bugs.webkit.org/show_bug.cgi?id=114412

Attachment 197724: Patch
https://bugs.webkit.org/attachment.cgi?id=197724&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197724&action=review


> LayoutTests/css3/compositing/effect-background-blend-mode-color.html:7
> +  if (window.testRunner)
> +   
window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled",
"1");
> +
> +  if (window.testRunner)
> +    window.testRunner.dumpAsText(true);

Make this one conditional statement.

> LayoutTests/css3/compositing/effect-background-blend-mode-color2.html:7
> +  if (window.testRunner)
> +   
window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled",
"0");
> +
> +  if (window.testRunner)
> +    window.testRunner.dumpAsText(true);

Same here.


More information about the webkit-reviews mailing list