[webkit-reviews] review granted: [Bug 114983] [GTK] Enable introspection always for developer builds : [Attachment 199107] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 114983: [GTK] Enable introspection always for developer builds
https://bugs.webkit.org/show_bug.cgi?id=114983

Attachment 199107: Patch
https://bugs.webkit.org/attachment.cgi?id=199107&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199107&action=review


> Source/WebKit2/ChangeLog:8
> +	   * GNUmakefile.am: Make warnings cause the build to fail. Eliminate

Be good to make it obvious you're talking about the scanner build here.

> Source/WebKit/gtk/GNUmakefile.am:300
> -	$(AM_V_GEN)$(G_IR_SCANNER) -v --warn-all \
> +	$(AM_V_GEN) \
> +	     CFLAGS="$(CFLAGS) -Wno-deprecated-declarations" \
> +	     $(G_IR_SCANNER) \
> +	     --quiet \

Is girscanner still verbose enough to help debug issues shown by the EWS after
replacing -v with --quiet here? Other than that it's a great idea, and the
patch looks OK to me.