[webkit-reviews] review granted: [Bug 114938] PDFPlugin: Support unlocking encrypted PDFs : [Attachment 199106] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 114938: PDFPlugin: Support unlocking encrypted PDFs
https://bugs.webkit.org/show_bug.cgi?id=114938

Attachment 199106: patch
https://bugs.webkit.org/attachment.cgi?id=199106&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199106&action=review


> Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:28
> +#if ENABLE(PDFKIT_PLUGIN)
> +
> +#import "config.h"

I think that ENABLE macros won't work before config.h.

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:43
> +using namespace WebCore;
> +
> +namespace WebKit {
> +
> +using namespace HTMLNames;

Funny that using declarations are in different places.