[webkit-reviews] review granted: [Bug 114841] Objective-C API: Update public header documentation : [Attachment 198896] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 114841: Objective-C API: Update public header documentation
https://bugs.webkit.org/show_bug.cgi?id=114841

Attachment 198896: Patch
https://bugs.webkit.org/attachment.cgi?id=198896&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198896&action=review


r=me

> Source/JavaScriptCore/API/JSManagedValue.h:42
> +// be retained inside of the JSVirtualMachine. However, if neither of these 


Let's drop "inside the JSVirtualMachine" here and say, "the corresponding
JSValue will be retained". That puts things more in terms of classical Cocoa
programming.

> Source/JavaScriptCore/API/JSManagedValue.h:44
> +// conditions are true, the corresponding JavaScript value becomes a weak
value,
> +// meaning it can be released by the JavaScript garbage collector at any
time.

Here, let's say, "the corresponding JSValue will be released and set to nil".
We can hide the detail that it only becomes nil after the GC notices.