[webkit-reviews] review granted: [Bug 114987] fourthTier: Create an equivalent of Structure::get() that can work from a compilation thread : [Attachment 199095] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 114987: fourthTier: Create an equivalent of Structure::get() that can work
from a compilation thread
https://bugs.webkit.org/show_bug.cgi?id=114987

Attachment 199095: the patch
https://bugs.webkit.org/attachment.cgi?id=199095&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199095&action=review


> Source/JavaScriptCore/ChangeLog:73
> +2013-04-22  Filip Pizlo  <fpizlo at apple.com>
> +
> +	   * bytecode/GetByIdStatus.cpp:
> +	   (JSC::GetByIdStatus::computeFromLLInt):
> +	   (JSC::GetByIdStatus::computeForChain):
> +	   (JSC::GetByIdStatus::computeFor):
> +	   * bytecode/PutByIdStatus.cpp:
> +	   (JSC::PutByIdStatus::computeFromLLInt):
> +	   (JSC::PutByIdStatus::computeFor):
> +	   * runtime/PropertyMapHashTable.h:
> +	   (PropertyTable):
> +	   (JSC::PropertyTable::findConcurrently):
> +	   (JSC):
> +	   (JSC::PropertyTable::add):
> +	   (JSC::PropertyTable::remove):
> +	   (JSC::PropertyTable::reinsert):
> +	   (JSC::PropertyTable::rehash):
> +	   * runtime/PropertyTable.cpp:
> +	   (JSC::PropertyTable::PropertyTable):
> +	   * runtime/Structure.cpp:
> +	   (JSC::Structure::findStructuresAndMapForMaterialization):
> +	   (JSC::Structure::getConcurrently):
> +	   * runtime/Structure.h:

Duplicate changelog

> Source/JavaScriptCore/runtime/PropertyMapHashTable.h:366
> +    Locker locker(m_lock);

So add() locks, what about delete?  Do we need that to lock?

> Source/WTF/wtf/Locker.h:43
> +    Locker(AssumeLockedTag)
> +	   : m_lockable(0)
> +    {
> +    }

I wonder if there's someway we could add an assertion to make sure this is the
case