[webkit-reviews] review denied: [Bug 37245] When deciding whether to line-break inside shrink-to-fit containers do not include trailing space when determining width of content : [Attachment 198959] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 37245: When deciding whether to line-break inside shrink-to-fit containers
do not include trailing space when determining width of content
https://bugs.webkit.org/show_bug.cgi?id=37245

Attachment 198959: Patch
https://bugs.webkit.org/attachment.cgi?id=198959&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198959&action=review


r-

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:3259
> +	   if (checkForBreak &&
!width.fitsOnLine(m_block->isFloatingOrOutOfFlowPositioned())) {

Shouldn't it be all shrink to fit and not just floating or positioned? What
about say inline blocks?

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:3297
> +    if (width.fitsOnLine(m_block->isFloatingOrOutOfFlowPositioned()) ||
lastWS == NOWRAP)

Same.