[webkit-reviews] review granted: [Bug 114962] Cancelling load may cause deadlock in -[AVPlayerItem release] : [Attachment 199051] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 22 11:43:52 PDT 2013


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 114962: Cancelling load may cause deadlock in -[AVPlayerItem release]
https://bugs.webkit.org/show_bug.cgi?id=114962

Attachment 199051: Patch
https://bugs.webkit.org/attachment.cgi?id=199051&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199051&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1627
> +	   if (!m_callback->shouldWaitForLoadingOfResource(loadingRequest))

This should check to make sure m_callback is not NULL.


More information about the webkit-reviews mailing list