[webkit-reviews] review granted: [Bug 114941] Scrollbar should not depend on EventHandler, Frame and FrameView : [Attachment 199006] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 114941: Scrollbar should not depend on EventHandler, Frame and FrameView
https://bugs.webkit.org/show_bug.cgi?id=114941

Attachment 199006: Patch
https://bugs.webkit.org/attachment.cgi?id=199006&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199006&action=review


> Source/WebCore/ChangeLog:14
> +	   It's a layering violation that Scrollbar uses EventHandler, Frame
> +	   and FrameView. Frame is used to get the EvenHandler that is used
> +	   to set mousePressed to false after a Scrollbar::mouseUp(). This is
> +	   not really needed, since EvenHandler already sets m_mousePressed
> +	   to false when calling Scrollbar::mouseUp(). The PopupMenu windows
> +	   implementation also calls Scrollbar::mouseUp(), but that scrollbar
> +	   is not inside a FrameView.

Some EvenHandler typos here.