[webkit-reviews] review denied: [Bug 114949] Initial advance of text runs should be taken into account : [Attachment 199018] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Antoine Quint <graouts at apple.com>'s
request for review:
Bug 114949: Initial advance of text runs should be taken into account
https://bugs.webkit.org/show_bug.cgi?id=114949

Attachment 199018: Patch
https://bugs.webkit.org/attachment.cgi?id=199018&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199018&action=review


> Source/WebCore/platform/graphics/GlyphBuffer.h:133
> +    void setInitialAdvance(CGSize anAdvance) { m_initialAdvance = anAdvance;
}
> +    const CGSize initialAdvance() const { return m_initialAdvance; }

It’s not acceptable to use a Mac-specific type, CGSize, here in a platform
independent class; maybe FloatSize instead? Also, the return type need not have
a const. Further, WebKit coding style does not use prefixes like “an”.