[webkit-reviews] review denied: [Bug 114861] [BlackBerry] Add dummy implementations of some methods : [Attachment 198828] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 22 00:50:50 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has denied Alberto Garcia
<agarcia at igalia.com>'s request for review:
Bug 114861: [BlackBerry] Add dummy implementations of some methods
https://bugs.webkit.org/show_bug.cgi?id=114861

Attachment 198828: Patch
https://bugs.webkit.org/attachment.cgi?id=198828&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198828&action=review


> Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp:99
> +String DragData::droppedFileSystemId() const
> +{
> +    notImplemented();
> +    return String();
> +}

This should be inside a #if ENABLE(FILE_SYSTEM) block.


More information about the webkit-reviews mailing list