[webkit-reviews] review denied: [Bug 114929] Web Inspector: ConsoleMessage should include line and column number where possible : [Attachment 198979] [PATCH] Add column number alongside line number

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 114929: Web Inspector: ConsoleMessage should include line and column number
where possible
https://bugs.webkit.org/show_bug.cgi?id=114929

Attachment 198979: [PATCH] Add column number alongside line number
https://bugs.webkit.org/attachment.cgi?id=198979&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198979&action=review


This basically looks fine to me, but i'm going to r- it anyway because i'm
annoying.  We now _always_ generate a stack trace when we throw an exception,
we may as well just show it in the console (either in line, or via a drop down,
i'm easy with either, but i also wouldn't want me designing UI for anything so
I'm going to leave the decision with you)

>>> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:277
>>> +					       unsigned int lineNumber,
unsigned columnNumber, const String& sourceID)
>> 
>> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]
> 
> Omit int when using unsigned	[runtime/unsigned] [1]

You're changing this line, you may as well fix the style foible

>>> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h:87
>>> +					  unsigned int lineNumber, unsigned
columnNumber, const String& sourceID);
>> 
>> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]
> 
> Omit int when using unsigned	[runtime/unsigned] [1]

ditto