[webkit-reviews] review granted: [Bug 114907] Fix some minor bad use of strings in WebCore : [Attachment 198950] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 20 22:02:45 PDT 2013


Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 114907: Fix some minor bad use of strings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114907

Attachment 198950: Patch
https://bugs.webkit.org/attachment.cgi?id=198950&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198950&action=review


> Source/WebCore/ChangeLog:9
> +	   (WebCore::Editor::selectedText): This was implictely getting the
emptyString().

Typo or spelling error: should be "implicitly".

But also, I don’t understand what you mean. Do you mean that 0 was turning into
the null string?


More information about the webkit-reviews mailing list