[webkit-reviews] review granted: [Bug 114807] Division by zero in CSSGradientValue::addStops() : [Attachment 198841] Updated patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 114807: Division by zero in CSSGradientValue::addStops()
https://bugs.webkit.org/show_bug.cgi?id=114807

Attachment 198841: Updated patch
https://bugs.webkit.org/attachment.cgi?id=198841&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198841&action=review


> Source/WebCore/css/CSSGradientValue.cpp:347
> -	       for (size_t i = 0; i < numStops; ++i)
> -		   stops[i].offset = (stops[i].offset - firstOffset) / scale;
> +		   for (size_t i = 0; i < numStops; ++i)
> +		       stops[i].offset = (stops[i].offset - firstOffset) /
scale;

I'm seeing darker green in the diff here. Are they tab characters? Maybe it's
just highlighting the extra indentation.