[webkit-reviews] review granted: [Bug 114895] SunSpider/string-tagcloud should be more lenient in validating its results, since they depend on Math.log, which isn't formally specified : [Attachment 198923] the patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 114895: SunSpider/string-tagcloud should be more lenient in validating its
results, since they depend on Math.log, which isn't formally specified
https://bugs.webkit.org/show_bug.cgi?id=114895

Attachment 198923: the patch
https://bugs.webkit.org/attachment.cgi?id=198923&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198923&action=review


r=me

> PerformanceTests/SunSpider/tests/sunspider-1.0/string-tagcloud.js:266
> +var expectedMinLength = 315000;

How did you come up with this being enough in all cases?