[webkit-reviews] review granted: [Bug 114886] Remove the remaining Skia #ifdefs : [Attachment 198906] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 20 01:31:00 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 114886: Remove the remaining Skia #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=114886

Attachment 198906: Patch
https://bugs.webkit.org/attachment.cgi?id=198906&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198906&action=review


Awesome!

> Source/WebCore/platform/graphics/GraphicsContext.cpp:861
> +#if !USE(CG) // append && !USE(MYPLATFORM) here to optimize ellipses on your
platform.

That comment is pretty dumb. You can remove it.


More information about the webkit-reviews mailing list