[webkit-reviews] review denied: [Bug 113405] Respect image-rendering setting for determing image-rendering quality : [Attachment 198837] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 20 01:11:45 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 113405: Respect image-rendering setting for determing image-rendering
quality
https://bugs.webkit.org/show_bug.cgi?id=113405

Attachment 198837: Patch
https://bugs.webkit.org/attachment.cgi?id=198837&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
So you replaced the coverage of -webkit-optimize-contrast by
-webkit-crisp-edges then verify they are equivalent with a ref-test? Make
sense.

Can you please add one more? A text test checking the style and computed style
for images with -webkit-optimize-contrast, -webkit-crisp-edges, and the default
value of image-rendering? With js-test-pre, you can do stuff like
shouldBeEqualToString('element.imageRender', '-webkit-crip-edges').


More information about the webkit-reviews mailing list