[webkit-reviews] review granted: [Bug 113965] Add interfaces and stubs for audio and video tracks : [Attachment 198913] Generate isReachableFromOpaqueRoots() and fix mac build again

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 113965: Add interfaces and stubs for audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=113965

Attachment 198913: Generate isReachableFromOpaqueRoots() and fix mac build
again
https://bugs.webkit.org/attachment.cgi?id=198913&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198913&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:2889
> +void
HTMLMediaElement::mediaPlayerDidRemoveAudioTrack(PassRefPtr<AudioTrackPrivate>
prpTrack)
> +{
> +    prpTrack->willBeRemoved();
> +}
> +
> +void
HTMLMediaElement::mediaPlayerDidRemoveTextTrack(PassRefPtr<InbandTextTrackPriva
te> prpTrack)
> +{
> +    prpTrack->willBeRemoved();
> +}
> +
> +void
HTMLMediaElement::mediaPlayerDidRemoveVideoTrack(PassRefPtr<VideoTrackPrivate>
prpTrack)
> +{
> +    prpTrack->willBeRemoved();
>  }

This looks much better.  It seems like, in theory, MediaPlayerPrivates could
remove the middle-man and just call VideoTrackPrivate::willBeRemoved()
directly, but there's nothing keeping both approaches from working with this
patch.