[webkit-reviews] review denied: [Bug 114809] [WK2][GTK] ExceededDatabaseQuota method/signal support in WebKitUIClient : [Attachment 198898] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Danilo Cesar Lemes de Paula
<danilo.cesar at collabora.co.uk>'s request for review:
Bug 114809: [WK2][GTK] ExceededDatabaseQuota method/signal support in
WebKitUIClient
https://bugs.webkit.org/show_bug.cgi?id=114809

Attachment 198898: Patch
https://bugs.webkit.org/attachment.cgi?id=198898&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198898&action=review


The signal is per-WebView, but the setting you are adding is per WebContext. I
think this might be a better candidate for a WebSetting (applies to all
WebViews in a WebViewGroup) or something more fine-grained. Having a setting on
the WebContext does not allow you to create WebViews with different quotas.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:200
> +							guint64 	       
      *defaultQuota);

You should use default_quota here, defaultQuota in the C++ implementation file,
and default_quota for the documentation.

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1356
>> +			 G_TYPE_UINT64);
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

You can ensure your code passes the style bot by uploading your patches with
webkit-patch.