[webkit-reviews] review granted: [Bug 113433] ContainerNode::removeChildren should first detach the children then remove them : [Attachment 198725] Simple version of the patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 113433: ContainerNode::removeChildren should first detach the children then
remove them
https://bugs.webkit.org/show_bug.cgi?id=113433

Attachment 198725: Simple version of the patch
https://bugs.webkit.org/attachment.cgi?id=198725&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198725&action=review


>>> Source/WebCore/dom/ContainerNode.cpp:633
>>> +		     removedChildren.append(n.release());
>> 
>> Why aren't we moving this loop before the other loop?
>> Is the comment you removed no longer applicable?
> 
> No, it's not applicable. The pointers are fixed after each node is removed
and I didn't find any evidence of detachment being faster for removed nodes
that a new iteration through them is worth the effort.

Please clarify that in the change log.