[webkit-reviews] review requested: [Bug 74144] [CSS Regions] Elements in a region should be assignable to a named flow : [Attachment 198890] patch that's 0.7-1.0% slower in the performance tests instead of 9.5%
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 19 09:05:23 PDT 2013
Mihai Maerean <mmaerean at adobe.com> has asked for review:
Bug 74144: [CSS Regions] Elements in a region should be assignable to a named
flow
https://bugs.webkit.org/show_bug.cgi?id=74144
Attachment 198890: patch that's 0.7-1.0% slower in the performance tests
instead of 9.5%
https://bugs.webkit.org/attachment.cgi?id=198890&action=review
------- Additional Comments from Mihai Maerean <mmaerean at adobe.com>
Running the performance tests on 2 machines gets only 0.7-1.0% bigger times
instead of the 9.5% of the previous patch.
The big performance impact of the previous patch was caused by always setting
m_style = element->styleForRenderer() in
NodeRenderingContext::createRendererForElementIfNeeded() even if the style was
already computed and stored in m_style.
More information about the webkit-reviews
mailing list