[webkit-reviews] review granted: [Bug 109588] [Texmap] Implementation for pattern compositing : [Attachment 198850] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 19 06:53:21 PDT 2013
Allan Sandfeld Jensen <allan.jensen at digia.com> has granted Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 109588: [Texmap] Implementation for pattern compositing
https://bugs.webkit.org/show_bug.cgi?id=109588
Attachment 198850: Patch
https://bugs.webkit.org/attachment.cgi?id=198850&action=review
------- Additional Comments from Allan Sandfeld Jensen <allan.jensen at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198850&action=review
LGTM
> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:124
> + if (m_state.solidColor.isValid() && !m_state.contentsRect.isEmpty() &&
m_state.solidColor.alpha()) {
Unrelated optimization, isn't it?
But I will let it slide.
More information about the webkit-reviews
mailing list