[webkit-reviews] review denied: [Bug 114844] [BLACKBERRY]fixed debug broken from previous patch : [Attachment 198787] fixed debug broken from previous patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 22:24:25 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied xuefeiren
<xren at blackberry.com>'s request for review:
Bug 114844: [BLACKBERRY]fixed debug broken from previous patch
https://bugs.webkit.org/show_bug.cgi?id=114844

Attachment 198787: fixed debug broken from previous patch
https://bugs.webkit.org/attachment.cgi?id=198787&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198787&action=review


> Source/WebKit/blackberry/ChangeLog:10
> +	   add missing parameter in 
> +	   Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp
> +	   void RenderQueue::scrollZoomJobsCompleted

add -> Add

Remove those lines...

> Source/WebKit/blackberry/ChangeLog:13
> +	   * WebKitSupport/RenderQueue.cpp:
> +	   (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):

Add a short description here.

> Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp:885
>      ASSERT(outstandingJobs.isEmpty());

This should be ASSERT_UNUSED.


More information about the webkit-reviews mailing list