[webkit-reviews] review denied: [Bug 114842] The nonCompositedContentLayer does not show even if WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1. : [Attachment 198786] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 18:48:24 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Keonil Jeong
<keonil.jeong at lge.com>'s request for review:
Bug 114842: The nonCompositedContentLayer does not show even if
WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1.
https://bugs.webkit.org/show_bug.cgi?id=114842

Attachment 198786: Patch
https://bugs.webkit.org/attachment.cgi?id=198786&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198786&action=review


> Source/WebKit2/ChangeLog:8
> +	   WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1.
> +	   https://bugs.webkit.org/show_bug.cgi?id=114842
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

You changelog needs an explanation for the change:
-Why the previous code was incorrect.
-Why the new code is correct.


More information about the webkit-reviews mailing list