[webkit-reviews] review denied: [Bug 114672] should null check mainResourceLoader() before use it : [Attachment 198717] add a test case, thanks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 14:12:04 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Mary Wu
<mary.wu at torchmobile.com.cn>'s request for review:
Bug 114672: should null check mainResourceLoader() before use it
https://bugs.webkit.org/show_bug.cgi?id=114672

Attachment 198717: add a test case, thanks
https://bugs.webkit.org/attachment.cgi?id=198717&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198717&action=review


> Source/WebCore/ChangeLog:8
> +	   Add a manual test which will cause mainResourceLoader return null.

ManualTests are bad.
The changelog should explain why it cannot be tested in any other way.


More information about the webkit-reviews mailing list