[webkit-reviews] review denied: [Bug 114696] Wrong use of REALTIME clock causes pages to fail loading : [Attachment 198580] Webkit patch for invalid uses of REALTIME clock

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 11:03:57 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 114696: Wrong use of REALTIME clock causes pages to fail loading
https://bugs.webkit.org/show_bug.cgi?id=114696

Attachment 198580: Webkit patch for invalid uses of REALTIME clock
https://bugs.webkit.org/attachment.cgi?id=198580&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198580&action=review


> Source/WebCore/workers/WorkerRunLoop.cpp:56
>  
>      // SharedTimer interface.
>      virtual void setFiredFunction(void (*function)()) {
m_sharedTimerFunction = function; }
> -    virtual void setFireInterval(double interval) { m_nextFireTime =
interval + currentTime(); }
> +    virtual void setFireInterval(double interval) { m_nextFireTime =
interval + monotonicallyIncreasingTime(); }

Wait, but why is this correct?


More information about the webkit-reviews mailing list