[webkit-reviews] review denied: [Bug 109013] AX: html native landmarks (header, section, footer) should have their own role descriptions instead of reusing the ARIA role descriptions (banner, region, contentinfo) : [Attachment 198688] patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied James Craig
<james at cookiecrook.com>'s request for review:
Bug 109013: AX: html native landmarks (header, section, footer) should have
their own role descriptions instead of reusing the ARIA role descriptions
(banner, region, contentinfo)
https://bugs.webkit.org/show_bug.cgi?id=109013

Attachment 198688: patch
https://bugs.webkit.org/attachment.cgi?id=198688&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198688&action=review


> Source/WebCore/English.lproj/Localizable.strings:688
> +/* accessibility role description for header element */

it seems confusing on the web to have a header and a heading. is there a
difference?

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1884
> +		   if (m_object->renderer()->node()->hasTagName(headerTag))

the platform object shouldn't be reaching into the AX object like this. If this
is a different role, then it should have a different AcccessibilityRole