[webkit-reviews] review granted: [Bug 83681] [GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API : [Attachment 198735] Rebased to current git master

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 83681: [GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=83681

Attachment 198735: Rebased to current git master
https://bugs.webkit.org/attachment.cgi?id=198735&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198735&action=review


> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:140
> +    WebURLRequest* newRequest =
WebURLRequest::create(webkitURIRequestGetResourceRequest(request.get())).leakRe
f();

I think you should put this in a RefPtr instead if calling leakRef() here.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:150
> +    return toAPI(newRequest);

Then you can call release().leakRef() here.