[webkit-reviews] review denied: [Bug 114670] [BLACKBERRY]fix warning(unused parameter) : [Attachment 198673] remove warning (unused parameter ) in platform/graphics/blackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 07:21:56 PDT 2013


Rob Buis <rwlbuis at gmail.com> has denied xuefeiren <xren at blackberry.com>'s
request for review:
Bug 114670: [BLACKBERRY]fix warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114670

Attachment 198673: remove warning (unused parameter ) in
platform/graphics/blackberry
https://bugs.webkit.org/attachment.cgi?id=198673&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198673&action=review


>
Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:238

> +void GraphicsContext3D::logFrameBufferStatus(int)

This is wrong, line is still being used in debug builds in BBLOG. You'll need
to test NDEBUG to do the right thing.


More information about the webkit-reviews mailing list