[webkit-reviews] review denied: [Bug 114740] Add checking whether the compiler allows to use #pragma directive. : [Attachment 198504] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 05:43:20 PDT 2013


Andreas Kling <akling at apple.com> has denied Krzysztof Wolanski
<k.wolanski at samsung.com>'s request for review:
Bug 114740: Add checking whether the compiler allows to use #pragma directive.
https://bugs.webkit.org/show_bug.cgi?id=114740

Attachment 198504: proposed patch
https://bugs.webkit.org/attachment.cgi?id=198504&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198504&action=review


> Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7
> +#if defined(_MSC_VER)

This should be #if COMPILER(MSVC)
Otherwise, it looks fine.


More information about the webkit-reviews mailing list