[webkit-reviews] review granted: [Bug 114779] Use StringJoiner to create the JSString of arrayProtoFuncToString : [Attachment 198668] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 114779: Use StringJoiner to create the JSString of arrayProtoFuncToString
https://bugs.webkit.org/show_bug.cgi?id=114779

Attachment 198668: Patch
https://bugs.webkit.org/attachment.cgi?id=198668&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198668&action=review


r=me

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:324
> +    return JSValue::encode(stringJoiner.build(exec));

As Ghost Dog would say, it is bad when one thing becomes two. It's a pet peeve
of mine when a class has a name like "string joiner" and its action function is
a different name like "build". This would read better as "stringJoiner.join()".
Oh well.